Better to revert than lose a community that is invested in your ecosystem that starts looking elsewhere. I congratulate the team in acknowledging and doing the right thing. As a developer myself, I know it is a painful thing to do but important to listen to the community.
I’ve experienced this myself. I’ve had to downgrade my opinion of my own code. LLMs are great at pointing out the edge cases that you might have taken years to find. Honestly feels quite dispiriting but we move on.
Seems like this is more about the introduction of LLM code reviews that has found edge cases that would have otherwise been missed and fixed as they appeared over years in the future. The issue is that the volume of issues has been beyond what people could do in time.
The blog post mentions rising standards of quality enabled by AI-assisted code review, and that reverted code predates the era of AI. Even very competently managed codebases are not above mistakes, especially when held to as high of a standard as this.
I’ve noticed the GitHub copilot reviews have gone from mostly nitpicks to very complicated issues that are hard to even understand or validate. Some of these are incorrect but some of them are actual findings of issues that simply would have gone unaddressed previously.
So a lot of this increase in bug reports lately is simply that we are more able to find issues which would previously have been shipped and probably wouldn’t have even been noticed by users for a long time. The minimum bar for software quality is going up, there's no excuse to ship software which contains bugs that could be detected by an LLM.
GP is referring to the submission, in case that wasn't obvious. It's opining as to possible reasons, given the author is one of the people who had a feature reverted.
> Did someone not understand what went in?
Unlikely, from the context.
> Might someone have offloaded their thinking to some external tool?
No, according to the author, since the features predate most current LLM assisted coding.
> Did people stop caring?
I'm not sure what this means. Presumably things were reverted because people cared enough to make sure it was good quality before being released.
> Did someone not plan or design a feature in full?
An admitted possibility
> Were the timelines unrealistic?
Depending on what you mean, that may be correct according to the article, but I suspect not in the way you mean.
> Maybe with so many reverts timelines should be revised?
It sounds like there was a very large increase in load in some of the people that would commonly review during this time period, and that may or may not continue to happen to a greater or lesser degree in the future, it depends on how LLMs advance in finding bugs and if there are other large waved of bugs reported.
Take any codebase you built in the pre-AI era and run it through AI review. I guarantee, no matter how smart you are or how diligently you write tests, you will be absolutely gobsmacked by the findings. Turns out we haven't been writing perfect software all this time and we have some catching up to do.
A bunch of features that made it to beta turned out not to be in a state that could be made satisfactory for release time and so was reverted.
That seems to me to be the right thing to do. Unfortunate, but the right thing to do.
“[something] will continue until morale improves” is usually a sacastic dig at tone deaf and incompetent leadership (e.g, “firing will continue until morale improves”)
It's a play on "the beatings will continue until morale improves". You obviously can't just beat morale into people, and, knowing that, the audience should understand improvements to a bad situation will not be forthcoming. It's often used for dramatic effect as dark/silly humor when something bad happens.
Yes, not only is there always improvements to existing functionality possible due to changes in improvements in general software engineering and mathematical methods beyond it or supporting new hardware features.
Generally, software engineering like other industries is evolving and there is need for different facilities. Consider graph and vector databases featuring, as well as json columns as examples of things you that are relatively recently in common use.
Better to revert than lose a community that is invested in your ecosystem that starts looking elsewhere. I congratulate the team in acknowledging and doing the right thing. As a developer myself, I know it is a painful thing to do but important to listen to the community.
I’ve experienced this myself. I’ve had to downgrade my opinion of my own code. LLMs are great at pointing out the edge cases that you might have taken years to find. Honestly feels quite dispiriting but we move on.
Seems like this is more about the introduction of LLM code reviews that has found edge cases that would have otherwise been missed and fixed as they appeared over years in the future. The issue is that the volume of issues has been beyond what people could do in time.
Reverts kind of suck when it's your feature getting reverted, no doubt. But for something as foundational as Postgres, the more reverts the better...
[flagged]
The blog post mentions rising standards of quality enabled by AI-assisted code review, and that reverted code predates the era of AI. Even very competently managed codebases are not above mistakes, especially when held to as high of a standard as this.
I’ve noticed the GitHub copilot reviews have gone from mostly nitpicks to very complicated issues that are hard to even understand or validate. Some of these are incorrect but some of them are actual findings of issues that simply would have gone unaddressed previously.
So a lot of this increase in bug reports lately is simply that we are more able to find issues which would previously have been shipped and probably wouldn’t have even been noticed by users for a long time. The minimum bar for software quality is going up, there's no excuse to ship software which contains bugs that could be detected by an LLM.
Well I have a document for you to read on this very question!
[flagged]
GP is referring to the submission, in case that wasn't obvious. It's opining as to possible reasons, given the author is one of the people who had a feature reverted.
> Did someone not understand what went in?
Unlikely, from the context.
> Might someone have offloaded their thinking to some external tool?
No, according to the author, since the features predate most current LLM assisted coding.
> Did people stop caring?
I'm not sure what this means. Presumably things were reverted because people cared enough to make sure it was good quality before being released.
> Did someone not plan or design a feature in full?
An admitted possibility
> Were the timelines unrealistic?
Depending on what you mean, that may be correct according to the article, but I suspect not in the way you mean.
> Maybe with so many reverts timelines should be revised?
It sounds like there was a very large increase in load in some of the people that would commonly review during this time period, and that may or may not continue to happen to a greater or lesser degree in the future, it depends on how LLMs advance in finding bugs and if there are other large waved of bugs reported.
Huh?
Take any codebase you built in the pre-AI era and run it through AI review. I guarantee, no matter how smart you are or how diligently you write tests, you will be absolutely gobsmacked by the findings. Turns out we haven't been writing perfect software all this time and we have some catching up to do.
I’m not sure I like the headline.
A bunch of features that made it to beta turned out not to be in a state that could be made satisfactory for release time and so was reverted.
That seems to me to be the right thing to do. Unfortunate, but the right thing to do.
“[something] will continue until morale improves” is usually a sacastic dig at tone deaf and incompetent leadership (e.g, “firing will continue until morale improves”)
I don’t think that is fair to say here.
I don’t get the meaning of the article subject.
It's a play on "the beatings will continue until morale improves". You obviously can't just beat morale into people, and, knowing that, the audience should understand improvements to a bad situation will not be forthcoming. It's often used for dramatic effect as dark/silly humor when something bad happens.
What, the title? "Until morale improves" is ineptly chosen, because it seems self-deprecating: https://quoteinvestigator.com/2020/07/15/morale/
Or if not the title, the general context is this: https://news.ycombinator.com/item?id=50119991
It is a play on the old joke “The beatings will continue until morale approves.”
This is a strong endorsement of postgres; it shows they take quality control seriously.
> as far as I can tell, this situation is not due to “vibe coding”. This code was written well before that was a possibility.
Since people refuse to read things on HN, I might as well bubble up this particular bullet point.
is it really necessary to keep using new version of postgres and to keep developing them? is it not done at this point?
Yes, not only is there always improvements to existing functionality possible due to changes in improvements in general software engineering and mathematical methods beyond it or supporting new hardware features.
Generally, software engineering like other industries is evolving and there is need for different facilities. Consider graph and vector databases featuring, as well as json columns as examples of things you that are relatively recently in common use.
Yes. There's always room for improvement.
[flagged]